Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent app with duplicate routes from being deployed to Cloud #208

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

itowlson
Copy link
Contributor

The current plugin allows an app to be deployed with duplicate routes. This fails in Cloud at runtime with a ghost error. This PR makes it fail deployment.

ivan@hestia:~/testing/dup-routes$ spin cloud deploy
Error: This application contains duplicate routes, which are not allowed in Fermyon Cloud.
- Route '/...' appears in components 'dupier-routes' and 'dup-routes'

Learn more at https://developer.fermyon.com/cloud/faq

(the FAQ is unhelpful here, but cannot currently be suppressed on a case-by-case basis)

Signed-off-by: itowlson <ivan.towlson@fermyon.com>
@itowlson itowlson requested a review from bacongobbler July 17, 2024 20:28
@itowlson itowlson merged commit fa54746 into fermyon:main Jul 17, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants