Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port prosemirror-transform changes up to 1.7.1 #211

Merged
merged 5 commits into from
May 19, 2023
Merged

Port prosemirror-transform changes up to 1.7.1 #211

merged 5 commits into from
May 19, 2023

Conversation

p7g
Copy link
Contributor

@p7g p7g commented May 10, 2023

Upstream changes: ProseMirror/prosemirror-transform@1.6.0...1.7.1

In particular, this adds AddNodeMarkStep and RemoveNodeMarkStep, and a fix to replace_step.

The regression in ProseMirror/prosemirror-transform@aadd102 came about during the TypeScript migration so it doesn't need any changes here.

@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Patch coverage: 81.67% and project coverage change: -0.15 ⚠️

Comparison is base (d125a6a) 87.36% compared to head (35dbc1a) 87.22%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #211      +/-   ##
==========================================
- Coverage   87.36%   87.22%   -0.15%     
==========================================
  Files          27       28       +1     
  Lines        3008     3147     +139     
==========================================
+ Hits         2628     2745     +117     
- Misses        380      402      +22     
Impacted Files Coverage Δ
prosemirror/transform/transform.py 92.87% <62.50%> (-1.46%) ⬇️
prosemirror/transform/mark_step.py 78.14% <81.53%> (+2.56%) ⬆️
prosemirror/transform/attr_step.py 83.78% <83.78%> (ø)
prosemirror/model/schema.py 86.99% <100.00%> (ø)
prosemirror/transform/replace.py 98.67% <100.00%> (+0.05%) ⬆️

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@p7g p7g merged commit 32bbd84 into main May 19, 2023
@p7g p7g deleted the node-mark-steps branch May 19, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants