Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port upstream changes #174

Merged
merged 4 commits into from
Jul 7, 2022
Merged

Port upstream changes #174

merged 4 commits into from
Jul 7, 2022

Conversation

ericls
Copy link
Contributor

@ericls ericls commented Jul 6, 2022

Upgrade
prosemirror-model to 1.81.1 (upstream-diff)
and prosemirror-transform to 1.6.0 (upstream diff)

@ericls ericls requested review from p7g and cpmsmith July 6, 2022 01:35
@codecov
Copy link

codecov bot commented Jul 6, 2022

Codecov Report

Merging #174 (677b318) into master (d9108af) will increase coverage by 0.13%.
The diff coverage is 95.23%.

@@            Coverage Diff             @@
##           master     #174      +/-   ##
==========================================
+ Coverage   87.22%   87.35%   +0.13%     
==========================================
  Files          27       27              
  Lines        2982     3022      +40     
==========================================
+ Hits         2601     2640      +39     
- Misses        381      382       +1     
Impacted Files Coverage Δ
prosemirror/model/schema.py 86.99% <75.00%> (-0.20%) ⬇️
prosemirror/model/fragment.py 92.38% <88.88%> (-0.33%) ⬇️
prosemirror/transform/transform.py 94.36% <95.00%> (-0.12%) ⬇️
prosemirror/model/node.py 82.53% <100.00%> (+0.13%) ⬆️
prosemirror/transform/map.py 80.79% <100.00%> (+3.43%) ⬆️
prosemirror/transform/replace.py 98.62% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9108af...677b318. Read the comment docs.

@aminland
Copy link

aminland commented Jul 6, 2022

Please also update the readme to indicate the relevant upstream versions

@ericls ericls marked this pull request as ready for review July 7, 2022 15:29
@ericls ericls requested review from aminland and sciyoshi July 7, 2022 15:33
@ericls ericls merged commit 5e5e62a into master Jul 7, 2022
@@ -69,6 +70,10 @@ def is_leaf(self):
def is_atom(self):
return self.is_leaf or self.spec.get("atom")

@property
def whitespace(self) -> Literal["pre", "normal"]:
return self.spec.get("whitespace") or ("pre" if self.spec else "normal")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be self.spec.code

@sciyoshi sciyoshi deleted the upstream-updates branch April 18, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants