Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New makefile targets #725

Merged
merged 5 commits into from
Feb 5, 2025
Merged

New makefile targets #725

merged 5 commits into from
Feb 5, 2025

Conversation

mmartinv
Copy link
Contributor

@mmartinv mmartinv commented Jan 30, 2025

Centralized all the build related tasks in the Makefile:
Add new source, vendor, create-packit-archive and tests targets.

Depends on #722

@mmartinv mmartinv force-pushed the new-makefile-targets branch 2 times, most recently from 83af3db to 250908c Compare January 30, 2025 14:28
@mmartinv mmartinv mentioned this pull request Jan 30, 2025
@mmartinv mmartinv force-pushed the new-makefile-targets branch from 250908c to 4379179 Compare January 30, 2025 16:28
@mmartinv mmartinv marked this pull request as ready for review January 30, 2025 16:30
@mmartinv mmartinv requested a review from a team January 30, 2025 16:30
runcom
runcom previously approved these changes Feb 5, 2025
@mmartinv mmartinv force-pushed the new-makefile-targets branch from 4379179 to 9bace29 Compare February 5, 2025 10:27
@mmartinv mmartinv force-pushed the new-makefile-targets branch 2 times, most recently from 2ba1dbc to b6cf916 Compare February 5, 2025 11:04
Add two new Makefile targets to generate the source and vendor
tarballs. This centralizes all the build related tasks in the
Makefile.

Renamed COMMIT to VERSION and used the `git describe --tags`
command to get a more meaninful version for the Tarballs/RPMs

Signed-off-by: Miguel Martín <mmartinv@redhat.com>
Add a new 'packit-create-archive' target to Makefile as
a shorcut of 'make source vendor' to use it in packit.

Signed-off-by: Miguel Martín <mmartinv@redhat.com>
Add a new 'test' Makefile target to be able to run
all the tests locally.

Signed-off-by: Miguel Martín <mmartinv@redhat.com>
Add the source code and vendor tarballs to
the .gitignore file

Signed-off-by: Miguel Martín <mmartinv@redhat.com>
Use the new `vendor` and `packit-create-archive` Makefile targets in Packit

Signed-off-by: Miguel Martín <mmartinv@redhat.com>
@mmartinv mmartinv force-pushed the new-makefile-targets branch from b6cf916 to 46fe027 Compare February 5, 2025 11:12
@mmartinv mmartinv requested a review from runcom February 5, 2025 11:29
@mmartinv mmartinv merged commit 096f8ed into fdo-rs:main Feb 5, 2025
21 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants