Add Presence Support #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add tests, initial syncState, syncDiff. - Use an updated dict merge function, because of this bug in Elm's Dict.Merge: https://github.com/elm-lang/core/pull/648 - Parameterize user payloads - Add documentation for Presence
|
When is PR will be merged? |
|
Thanks for your work @knewter! I put your |
|
@fbonetti Is there an ETA of when this might be merged? |
mjs2600
approved these changes
Oct 13, 2016
|
@fbonetti this has been sitting here for 6 months, please update |
|
Hey guys, sorry for being unresponsive for so long. I don't have time to maintain this project. If anyone would like to take ownership, I'd be happy to give you access to the repo. |
|
Thanks for this and sorry for the wait! I've reviewed, updated, and merged it. I'd like to add some more "transparent" mechanisms for tracking presence in the future, but I appreciate you were following the JS library. |
jeffcole
added a commit
to jeffcole/loops_with_friends
that referenced
this pull request
Jun 9, 2018
It's no longer necessary now that fbonetti/elm-phoenix-socket#16 has been merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dict.Merge: https://github.com/elm-lang/core/pull/648