Skip to content
This repository has been archived by the owner on Oct 2, 2018. It is now read-only.

Shell escape product name in build command #175

Merged
merged 1 commit into from
Jan 12, 2016
Merged

Shell escape product name in build command #175

merged 1 commit into from
Jan 12, 2016

Conversation

HughJeffner
Copy link
Contributor

Addressing issue #107
Tested with single quote and brackets in product name

@HughJeffner
Copy link
Contributor Author

I'm really not that familiar with ruby, do I need require 'shellwords'? I think my change may have only worked since package_command_generator.rb may have already loaded it first.

@KrauseFx
Copy link
Contributor

KrauseFx commented Jan 7, 2016

The require is fine. Sorry, but I think I caused a merge conflict. Could you resolve it and squash your commits into one?

@KrauseFx
Copy link
Contributor

KrauseFx commented Jan 7, 2016

Have you tested this change locally?

@HughJeffner
Copy link
Contributor Author

Yeah I just did a rake install and tested manually, is there a preferred way of testing?

KrauseFx added a commit that referenced this pull request Jan 12, 2016
@KrauseFx
Merge pull request #175 from HughJeffner/patch-1
68658d1 
Shell escape product name in build command
@KrauseFx KrauseFx merged commit 68658d1 into fastlane-old:master Jan 12, 2016
@KrauseFx
Copy link
Contributor

Perfect, thanks for your contribution @HughJeffner, this will be in the next release 👍

@HughJeffner HughJeffner deleted the patch-1 branch January 14, 2016 14:20
@fastlane-old fastlane-old locked and limited conversation to collaborators Mar 11, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HughJeffner @KrauseFx