Zip all dSYM files together #114
Conversation
When building an application with many frameworks, each framework will produce it's own dSYM file. These need to be included in the dSYM zip file to allow for symbolication of crashes in these frameworks. Really we just need the archive path, but this will allow for easy backward compatibility with existing code.
|
What's the easiest way for me to test it? Did you test the changes for one of your applications? |
|
How about I write some unit tests for this! I'd like to verify with a sample application and use that for this (just to ensure that non-framework apps don't break). Sound good? |
|
Perfect. I was not only talking about unit tests, but real world tests, that it works the way you do it. We don't want to break existing setups, so that suddenly their symbolication doesn't work. |
Totally agree, my fear is that people's symbolication is currently subtly broken as they are not including all dSYMs. I'll try to have a real world sample project for this change today or tomorrow. |
|
Hey @KrauseFx I've produced a sample project to demonstrate my changes available here, https://github.com/brianmichel/Framework-dSYM-test and I've upload a screenshot of what the output of a frameworks enabled archive looks like.
|
|
The frameworks I chose are obviously libraries available in the community, but you can easily imagine if you're using development pods to manage code across multiple targets, you'd absolutely want to include those symbols for crash reporting. |
|
Any word here? Would love some feedback if this is an actual problem for others. |
|
+1 for this. |
|
Any idea how to retrigger Travis? The output from the build isn't super helpful... |
|
Also looking forward to this (y) |
|
@vittoriom Have you tried this change? The code looks good, I'm a little afraid this might break something else. @brianmichel did you successfully submit an app to the App Store using this? |
|
@KrauseFx we do not submit from Gym, but we do use it as part of our process to upload to HockeyApp. Since using this change we are able to successfully symbolicate all of our logs that come from an application with many frameworks that we own. |
|
This should probably be tested with the Xcode 7 api, but if it's still broken (by Apple) it may be a non-issue. |
|
What I did is manually zip all the dSYMs and upload them on Hockey (where our live app is missing some symbolications) and now I can correctly see the symbols for the embedded frameworks, so I assume this is fine. |
|
@KrauseFx any word on this? Seems like others verified the same behavior, would love to not point to a fork of Gym. |
|
Would love for this feature to be implemented, this is the one blocker that prevents us completely switching over to gym to delivering a binary to iTunesConnect and having all the dSYMs uploaded to HockeyApp. |
…SYMs Zip all dSYM files together
|
Really sorry for the delay from my side. Thanks @brianmichel for working on this. I'm preparing a new release of gym right now 🚀 |
|
@KrauseFx Great news :-) |
|
If anyone is still paying attention to this PR, it's causing a (possibly unintended?) issue with our app when uploading to HockeyApp. Details here: #159 |
When building an application with many frameworks, each framework
will produce it's own dSYM file. These need to be included in the
dSYM zip file to allow for symbolication of crashes in these
frameworks.
Really we just need the archive path, but this will allow for
easy backward compatibility with existing code.