Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nbdev_new pins on major+minor version of nbdev-template #1091

Closed
seeM opened this issue Sep 18, 2022 · 3 comments
Closed

nbdev_new pins on major+minor version of nbdev-template #1091

seeM opened this issue Sep 18, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@seeM
Copy link
Contributor

seeM commented Sep 18, 2022

Since every version of nbdev uses latest nbdev-template, we can't make any breaking changes in nbdev-template. I propose that nbdev_new pins the major+minor version of nbdev-template and that nbdev-template bumps minor version on breaking changes.

Example

Implementing #1083 would be simpler with this change.

Currently, we can implement it by updating the default in _apply_defaults and having nbdev_new move a known list of files (*.ipynb, *.css) to cfg.nbs_path.

We wouldn't have to keep that list in our code if we could move those files into a new sub-dir of nbdev-template, but that would break nbdev_new for prior versions of nbdev.

cc @hamelsmu @jph00

@seeM seeM added the enhancement New feature or request label Sep 18, 2022
@jph00
Copy link
Contributor

jph00 commented Sep 18, 2022 via email

@seeM seeM changed the title nbdev_new pins on major version of nbdev-template nbdev_new pins on major+minor version of nbdev-template Sep 18, 2022
seeM added a commit to seeM/nbdev that referenced this issue Sep 18, 2022
@hamelsmu
Copy link
Contributor

hamelsmu commented Sep 19, 2022

sorry commented on the wrong issue

@seeM
Copy link
Contributor Author

seeM commented Sep 21, 2022

Closing. #1103 is a better solution to the underlying problem

@seeM seeM closed this as completed Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants