fix #1091: nbdev_new pins on major+minor version of nbdev-template
#1094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
hamelsmu
reviewed
Sep 19, 2022
| @@ -172,6 +172,25 @@ | |||
| " \"Use a token with the correction permissions or perform these steps manually.\")" | |||
There was a problem hiding this comment.
Line #13. tag = _nbdev_template_release((1,1)).tag_name
I wonder if there is a way to make it such that we can remind ourselves that we must change this line of code when we make a breaking change in the template repository. Surely, we will forget to this otherwise?
Any ideas?
Reply via ReviewNB
There was a problem hiding this comment.
Good point. I don't have a good answer yet, best I can think of is an e2e test for nbdev_new that (hopefully) fails if we forget to bump
There was a problem hiding this comment.
@jph00 I'm curious to hear your take on this
|
Closing. #1103 is a better solution to the underlying problem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nbdev_newpins on major+minor version ofnbdev-template#1091