Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pull missing messages into sync trie via sync health job #2326

Merged

Conversation

aditiharini
Copy link
Contributor

@aditiharini aditiharini commented Sep 20, 2024

There are cases where messages exist in the db but are missing from the trie. This happens primarily around restarts. When the sync health job sees "message has already been merged" it's an indication that the message exists in the db but not in the trie.

Deployed to hoyt for testing and it looks good.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review


PR-Codex overview

This PR adds missing messages to the sync trie via a sync health job.

Detailed summary

  • Added missing messages to sync trie
  • Updated processSumbitResults to handle already merged messages
  • Added numAlreadyMerged counter
  • Updated logging for merged messages

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Sep 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2024 6:09pm

Copy link

changeset-bot bot commented Sep 20, 2024

🦋 Changeset detected

Latest commit: 62d9d20

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@farcaster/hubble Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@aditiharini aditiharini added the t-feat Add a new feature or protocol improvement label Sep 20, 2024
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 7.69231% with 12 lines in your changes missing coverage. Please review.

Project coverage is 44.01%. Comparing base (1880070) to head (62d9d20).
Report is 364 commits behind head on main.

Files with missing lines Patch % Lines
apps/hubble/src/network/sync/syncHealthJob.ts 7.69% 12 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2326       +/-   ##
===========================================
- Coverage   74.05%   44.01%   -30.04%     
===========================================
  Files          99      146       +47     
  Lines        9425    25986    +16561     
  Branches     2097     9351     +7254     
===========================================
+ Hits         6980    11439     +4459     
- Misses       2327    12698    +10371     
- Partials      118     1849     +1731     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aditiharini aditiharini marked this pull request as ready for review September 20, 2024 18:13
@aditiharini aditiharini merged commit 5504e05 into farcasterxyz:main Sep 20, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-feat Add a new feature or protocol improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant