Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add start time and stop time to sync health logs #2323

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

aditiharini
Copy link
Contributor

@aditiharini aditiharini commented Sep 19, 2024

Why is this change needed?

Describe why this issue should be fixed and link to any relevant design docs, issues or other relevant items.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review


PR-Codex overview

This PR enhances the sync health job in hubble by adding more log tags and capturing start and stop times.

Detailed summary

  • Added start and stop time parameters to processSumbitResults function
  • Enhanced log details with startTime and stopTime in MeasureSyncHealthJobScheduler
  • Updated resultsPushingToUs with startTime and stopTime parameters

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Sep 19, 2024

🦋 Changeset detected

Latest commit: 8723706

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@farcaster/hubble Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Sep 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 19, 2024 10:12pm

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 44.01%. Comparing base (1880070) to head (8723706).
Report is 362 commits behind head on main.

Files with missing lines Patch % Lines
apps/hubble/src/network/sync/syncHealthJob.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2323       +/-   ##
===========================================
- Coverage   74.05%   44.01%   -30.05%     
===========================================
  Files          99      146       +47     
  Lines        9425    25969    +16544     
  Branches     2097     9226     +7129     
===========================================
+ Hits         6980    11431     +4451     
- Misses       2327    12738    +10411     
- Partials      118     1800     +1682     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aditiharini aditiharini merged commit 7206e8c into farcasterxyz:main Sep 19, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-chore Miscellaneous improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant