Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add metric to track events received by kind #2309

Merged

Conversation

aditiharini
Copy link
Contributor

@aditiharini aditiharini commented Sep 11, 2024

There are regular spikes in events received that aren't reflected in the hub metrics. This metric should be useful for understanding what kind of events are causing the spikes.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review


PR-Codex overview

This PR adds a metric for events processed with event type tag in the shuttle package.

Detailed summary

  • Added metric for events processed with event type tag in shuttle/eventStream.ts
  • Incremented attempt count for current and stale events
  • Added hubEventType tag to metrics
  • Calculated dequeue delay for events

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Sep 11, 2024

🦋 Changeset detected

Latest commit: d8b5fef

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@farcaster/shuttle Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Sep 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 11, 2024 7:38pm

@aditiharini aditiharini added the t-chore Miscellaneous improvements label Sep 11, 2024
@aditiharini aditiharini marked this pull request as ready for review September 11, 2024 19:38
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 44.31%. Comparing base (1880070) to head (d8b5fef).
Report is 347 commits behind head on main.

Files with missing lines Patch % Lines
packages/shuttle/src/shuttle/eventStream.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2309       +/-   ##
===========================================
- Coverage   74.05%   44.31%   -29.75%     
===========================================
  Files          99      146       +47     
  Lines        9425    25499    +16074     
  Branches     2097     9115     +7018     
===========================================
+ Hits         6980    11299     +4319     
- Misses       2327    12425    +10098     
- Partials      118     1775     +1657     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aditiharini aditiharini merged commit f6ba2b0 into farcasterxyz:main Sep 11, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-chore Miscellaneous improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant