fix: Use R2 for snapshots #1943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: aca5e22 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1943 +/- ##
===========================================
- Coverage 74.05% 48.74% -25.32%
===========================================
Files 99 118 +19
Lines 9425 15716 +6291
Branches 2097 4896 +2799
===========================================
+ Hits 6980 7661 +681
- Misses 2327 7391 +5064
- Partials 118 664 +546 ☔ View full report in Codecov by Sentry. |
adityapk00
added a commit
to adityapk00/hub
that referenced
this pull request
Apr 24, 2024
## Motivation Upload / download snapshots from R2 instead of S3 ## Merge Checklist _Choose all relevant options below by adding an `x` now or at any time before submitting for review_ - [X] PR title adheres to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standard - [X] PR has a [changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets) - [ ] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore) - [ ] PR includes [documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs) if necessary. - [X] All [commits have been signed](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#22-signing-commits) <!-- start pr-codex --> --- ## PR-Codex overview This PR updates the Hubble app to use R2 for snapshots and introduces a new `SNAPSHOT_S3_UPLOAD_BUCKET`. ### Detailed summary - Updated snapshot handling to use R2 - Added `SNAPSHOT_S3_UPLOAD_BUCKET` for uploading snapshots - Introduced `r2Endpoint` function for R2 endpoint configuration > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Upload / download snapshots from R2 instead of S3
Merge Checklist
Choose all relevant options below by adding an
xnow or at any time before submitting for reviewPR-Codex overview
This PR updates the Hubble app to use R2 for snapshots and introduces a new
SNAPSHOT_S3_UPLOAD_BUCKET.Detailed summary
SNAPSHOT_S3_UPLOAD_BUCKETfor uploading snapshotsr2Endpointfunction for R2 endpoint configuration