-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Faker::WorldCup YARD docs #1789
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor feedback :)
def stadium | ||
fetch('world_cup.stadiums') | ||
end | ||
|
||
## | ||
# Produces a random national team name from a group. See below examples |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can remove the "See below examples." from these descriptions :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright will do :)
Co-Authored-By: Connor Shea <connor.james.shea@gmail.com>
Co-Authored-By: Connor Shea <connor.james.shea@gmail.com>
Co-Authored-By: Connor Shea <connor.james.shea@gmail.com>
* add YARD docs * remove empty line * Update lib/faker/default/world_cup.rb Co-Authored-By: Connor Shea <connor.james.shea@gmail.com> * Update lib/faker/default/world_cup.rb Co-Authored-By: Connor Shea <connor.james.shea@gmail.com> * Update lib/faker/default/world_cup.rb Co-Authored-By: Connor Shea <connor.james.shea@gmail.com>
* add YARD docs * remove empty line * Update lib/faker/default/world_cup.rb Co-Authored-By: Connor Shea <connor.james.shea@gmail.com> * Update lib/faker/default/world_cup.rb Co-Authored-By: Connor Shea <connor.james.shea@gmail.com> * Update lib/faker/default/world_cup.rb Co-Authored-By: Connor Shea <connor.james.shea@gmail.com>
Add YARD docs for Faker::WorldCup [ #1762 ]