Skip to content

Commit

Permalink
Merge pull request #1173 from vbrazo/chores/remove-unused-test-variables
Browse files Browse the repository at this point in the history
Fix tests warning
  • Loading branch information
vbrazo authored May 12, 2018
2 parents f0961dd + d73de4b commit 4063853
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 8 deletions.
3 changes: 1 addition & 2 deletions lib/faker/elder_scrolls.rb
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,9 @@ def first_name
fetch('elder_scrolls.first_name')
end

def first_name
def last_name
fetch('elder_scrolls.last_name')
end

end
end
end
7 changes: 7 additions & 0 deletions test/test_faker_elder_scrolls.rb
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,11 @@ def test_name
assert @tester.name.match(/\w+/)
end

def test_first_name
assert @tester.first_name.match(/\w+/)
end

def test_last_name
assert @tester.last_name.match(/\w+/)
end
end
6 changes: 1 addition & 5 deletions test/test_faker_omniauth.rb
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,7 @@ def test_omniauth_google_with_name
auth = @tester.google(name: custom_name)
info = auth[:info]
extra_raw_info = auth[:extra][:raw_info]
id_info = auth[:id_info]


assert_instance_of String, info[:name]
assert_equal 2, word_count(info[:name])
assert_equal custom_name, info[:name]
Expand Down Expand Up @@ -184,7 +183,6 @@ def test_omniauth_facebook_with_email
def test_omniauth_facebook_with_uid
custom_uid = '12345'
auth = @tester.facebook(uid: custom_uid)
info = auth[:info]
extra_raw_info = auth[:extra][:raw_info]

assert_instance_of String, auth[:uid]
Expand Down Expand Up @@ -286,7 +284,6 @@ def test_omniauth_twitter_with_nickname
def test_omniauth_twitter_with_uid
custom_uid = '12345'
auth = @tester.twitter(uid: custom_uid)
info = auth[:info]
raw_info = auth[:extra][:raw_info]

assert_instance_of String, auth[:uid]
Expand Down Expand Up @@ -465,7 +462,6 @@ def test_omniauth_github_with_email
def test_omniauth_github_with_uid
custom_uid = '12345'
auth = @tester.github(uid: custom_uid)
info = auth[:info]
extra_raw_info = auth[:extra][:raw_info]

assert_instance_of String, auth[:uid]
Expand Down
2 changes: 1 addition & 1 deletion test/test_zh_locale.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
require File.expand_path(File.dirname(__FILE__) + '/test_helper.rb')

class TestZhCnLocale < Test::Unit::TestCase
class TestZhLocale < Test::Unit::TestCase
def setup
Faker::Config.locale = 'zh-CN'
end
Expand Down

0 comments on commit 4063853

Please sign in to comment.