Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(guide): fix link to helpers module #3289

Merged
merged 1 commit into from
Nov 30, 2024

Conversation

yoshi2no
Copy link
Contributor

thank you for maintaining such a fantastic library!

This PR corrected the URL for the helpers module in the documentation.
the section can be found here

@yoshi2no yoshi2no requested a review from a team as a code owner November 30, 2024 03:55
Copy link

netlify bot commented Nov 30, 2024

Deploy Preview for fakerjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 6ae1aeb
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/674a8c983ba27500081c784a
😎 Deploy Preview https://deploy-preview-3289.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (5d5fe30) to head (6ae1aeb).
Report is 1 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3289      +/-   ##
==========================================
- Coverage   99.97%   99.96%   -0.01%     
==========================================
  Files        2806     2806              
  Lines      217140   217140              
  Branches      982      981       -1     
==========================================
- Hits       217075   217068       -7     
- Misses         65       72       +7     

see 2 files with indirect coverage changes

@matthewmayer
Copy link
Contributor

Good catch! Thank you

Copy link
Member

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely spotted. Thanks for your contribution. ❤️

@ST-DDT ST-DDT added this pull request to the merge queue Nov 30, 2024
@ST-DDT ST-DDT removed this pull request from the merge queue due to a manual request Nov 30, 2024
@ST-DDT ST-DDT changed the title docs(guide): correct broken URL for helpers module docs(guide): fix link to helpers module Nov 30, 2024
@ST-DDT ST-DDT enabled auto-merge November 30, 2024 08:25
@ST-DDT ST-DDT added this pull request to the merge queue Nov 30, 2024
@ST-DDT ST-DDT added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent labels Nov 30, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Nov 30, 2024
Merged via the queue into faker-js:next with commit 42083ac Nov 30, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants