Extract Chromecast firmware version #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than put the CPU type as the OS version, for Chromecast, the
firmware version would be much more useful.
For example:
Mozilla/5.0 (X11; Linux aarch64) AppleWebKit/537.36 (KHTML, like
Gecko) Chrome/76.0.3809.81 Safari/537.36 CrKey/1.42.183786
This should produce:
os: { name: "Chromecast", version: "1.42.183786" }
Instead of:
os: { name: "Linux", version: "aarch64" }
shaka-bot
pushed a commit
to shaka-project/shaka-player
that referenced
this pull request
Aug 12, 2020
Our Chromecast tests have started reporting the device as "Linux aarch64", which is not useful. This moves us to a fork of ua-parser-js which can recognize a Chromecast and report its firmware version. A pull request has been submitted at faisalman/ua-parser-js#439. Change-Id: I158cc2b0dd6fb6ec03825ac9648b05a3096da31b
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than put the CPU type as the OS version, for Chromecast, the
firmware version would be much more useful.
For example:
Mozilla/5.0 (X11; Linux aarch64) AppleWebKit/537.36 (KHTML, like
Gecko) Chrome/76.0.3809.81 Safari/537.36 CrKey/1.42.183786
This should produce:
os: { name: "Chromecast", version: "1.42.183786" }
Instead of:
os: { name: "Linux", version: "aarch64" }