feat: [BACKEND] Description and cover has no translations in search results #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stadnicki
force-pushed
the
feature/EP-3252
branch
from
eb547e1 to
eb05528
Compare
matuz
approved these changes
Jan 10, 2023
espresse
requested changes
Jan 11, 2023
| @@ -0,0 +1,9 @@ | |||
| export interface LocalizationDto { | |||
| readonly object_id: string; | |||
There was a problem hiding this comment.
@Stadnicki do you really get object_id and not objectId property in localization objects? All properties should be camelCase in our services responses.
There was a problem hiding this comment.
You're right, I've missed that LocalizationOutputDto from edtech-localization-service is not eventual response shape as class-transformer is used.
Stadnicki
force-pushed
the
feature/EP-3252
branch
from
eb05528 to
c713e05
Compare
espresse
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.