-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/matrix utilization #7
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
Contains fix necessary for the scheduler to be able to read and fetch resource intervals even if they are not continuous.
Summary of updates (per function)
TaskAllocator.allocate_task
- The original implementation didn’t account for the scenario where both assignments and constraints matrices are present. It only solved the first available matrix (either assignments or constraints) using the or condition. The changes processes both constraints AND assignment matrices before constraints matrix gets trimmed so the values are much closer and will not throw a mismatch error.TaskAllocator._get_resource_intervals
- The updated version is more flexible and comprehensive, as it can handle multiple non-contiguous intervals per resource.TaskAllocator._find_indexes
- Uses vectorized operations on masked arrays to efficiently detect where the resource becomes available. Now detects both starts and ends of multiple windows using transition logic between masked and unmasked values and comparisons between consecutive values.Matrix.trim_end
- Allows differences within an absolute tolerance (atol=1e-8) to enable a more laid-back comparison.HeuristicSolver.solve
- Improved flexibility in the second version to handle multiple intervals per resource.