Skip to content

Commit

Permalink
{Build} Remove unused boost dependencies
Browse files Browse the repository at this point in the history
Summary: Boost chrono and thread are not longer required, we are removing here reference to them.

Differential Revision: D61272926
  • Loading branch information
SeaOtocinclus authored and facebook-github-bot committed Aug 14, 2024
1 parent 916af4b commit a7807b4
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build-and-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
cmake git ninja-build libgtest-dev libfmt-dev \
libturbojpeg-dev libpng-dev \
liblz4-dev libzstd-dev libxxhash-dev \
libboost-system-dev libboost-filesystem-dev libboost-thread-dev libboost-chrono-dev libboost-date-time-dev \
libboost-system-dev libboost-filesystem-dev libboost-date-time-dev \
qtbase5-dev portaudio19-dev
elif [ "$RUNNER_OS" == "macOS" ]; then
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ FROM ubuntu:jammy
RUN apt-get update && DEBIAN_FRONTEND="noninteractive" TZ="America/New_York" apt-get install -y tzdata
RUN apt-get install -y git cmake ninja-build ccache libgtest-dev libfmt-dev libturbojpeg-dev\
libpng-dev liblz4-dev libzstd-dev libxxhash-dev\
libboost-system-dev libboost-filesystem-dev libboost-thread-dev libboost-chrono-dev libboost-date-time-dev\
libboost-system-dev libboost-filesystem-dev libboost-date-time-dev\
qtbase5-dev portaudio19-dev\
npm doxygen;

Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ therefore not supported._
```
sudo apt-get install cmake git ninja-build ccache libgtest-dev libfmt-dev libturbojpeg-dev libpng-dev
sudo apt-get install liblz4-dev libzstd-dev libxxhash-dev
sudo apt-get install libboost-system-dev libboost-filesystem-dev libboost-thread-dev libboost-chrono-dev libboost-date-time-dev
sudo apt-get install libboost-system-dev libboost-filesystem-dev libboost-date-time-dev
sudo apt-get install qtbase5-dev portaudio19-dev
sudo apt-get install npm doxygen
```
Expand Down
2 changes: 0 additions & 2 deletions vrs/os/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,6 @@ target_link_libraries(vrs_os
vrs_logging
Boost::system
Boost::filesystem
Boost::thread
Boost::chrono
Boost::date_time
)
target_compile_definitions(vrs_os INTERFACE OSS_BUILD_MODE)
Expand Down

0 comments on commit a7807b4

Please sign in to comment.