This repository has been archived by the owner on May 6, 2024. It is now read-only.
Update helpers #55
Merged
Update helpers #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I couldn't get rid of the const for class_sym, but I moved it to a "from_mlet" static method now.
facebook-github-bot
added
the
CLA Signed
heiner
force-pushed
the
update-helpers
branch
4 times, most recently
from
7b272b2 to
a612b9f
Compare
edran
reviewed
Jul 29, 2020
Comment on lines
+160
to
+163
| .def_static( | ||
| "from_mlet", | ||
| [](char let) -> const class_sym * { return &def_monsyms[let]; }, | ||
| py::return_value_policy::reference) |
There was a problem hiding this comment.
This is... interesting. Was this to bypass const?
There was a problem hiding this comment.
NVM, I saw the comment in the commit.
There was a problem hiding this comment.
This is a bit of an unusual situation for pybind: NetHack maintains an array of class_sym structs. We invent a Python class for class_syms, but we don't actually want to create (or modify) any class_sym objects, just expose the entries of the array. Returning a pointer and using py::return_value_policy::reference makes pybind not take ownership.
What doesn't work is turning this into init with the py::nodelete trick as in permonst (same situation otherwise). So we'll just use this static method.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to have a slightly better handle on #21.