This repository has been archived by the owner on May 6, 2024. It is now read-only.
Require cmake version >= 3.14 #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrading from cmake version 3.13.1 made this error go away:
CMake Error at CMakeLists.txt:67 (install):
install TARGETS given no RUNTIME DESTINATION for executable target
"nethack".
facebook-github-bot
added
the
CLA Signed
rockt
approved these changes
Jul 23, 2020
Easy as pi!
edran
approved these changes
Jul 23, 2020
There was a problem hiding this comment.
Easy as pi!
😃
Regarding the PR, 3.14 is indeed the correct version to ensure compatibility. Sorry about that. CMake is supposed to warn us when there's a mismatch between minimum version and incompatible function calls, but this is probably a weird corner case and I didn't catch it myself either :(
No worries, and thanks for spotting my hidden joke. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading from cmake version 3.13.1 made this error go away:
CMake Error at CMakeLists.txt:67 (install):
install TARGETS given no RUNTIME DESTINATION for executable target
"nethack".