Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[baselines] Allow PointNav_GPSCompass to support dimensionality 3 #553

Merged
merged 2 commits into from
Jan 5, 2021
Merged

[baselines] Allow PointNav_GPSCompass to support dimensionality 3 #553

merged 2 commits into from
Jan 5, 2021

Conversation

Skylion007
Copy link
Contributor

Motivation and Context

Enables the ResNet baseline to support an integrated pointnav_gps_compass sensor of dimensionality 3. Previously only 2D Integrated PointNav/GPS Compass was supported.

How Has This Been Tested

  • Locally

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Dec 28, 2020
mathfac
mathfac approved these changes Dec 28, 2020
View reviewed changes
Copy link
Contributor

@mathfac mathfac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

erikwijmans
erikwijmans approved these changes Jan 4, 2021
View reviewed changes
Copy link
Contributor

@erikwijmans erikwijmans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably getting about time to refactor these additional observation encoders.

@Skylion007 Skylion007 merged commit 7e277c9 into master Jan 5, 2021
@Skylion007 Skylion007 deleted the pointnav_dimension_3 branch January 5, 2021 16:18
srama2512 pushed a commit that referenced this pull request Mar 15, 2023
@aclegg3
esp::core::Configuration derived Attributes refactor (#553)
e826d71 
* Replaced assets::Attributes class with expanded esp::core::Configuration class.

* update corrade to master
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
@Skylion007
[baselines] Allow PointNav_GPSCompass to support dimensionality 3 (fa…
c9a1ef9 
…cebookresearch#553)

* [baselines] Allow PointNav_GPSCompass to support dimensionality 3

* reviewer comments
HHYHRHY pushed a commit to SgtVincent/EMOS that referenced this pull request Aug 31, 2024
@Skylion007
[baselines] Allow PointNav_GPSCompass to support dimensionality 3 (fa…
0b99e36 
…cebookresearch#553)

* [baselines] Allow PointNav_GPSCompass to support dimensionality 3

* reviewer comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathfac mathfac mathfac approved these changes

@erikwijmans erikwijmans erikwijmans approved these changes

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Skylion007 @mathfac @erikwijmans @facebook-github-bot