Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PR] Fix AIX build break #3946

Closed
wants to merge 1 commit into from
Closed

[PR] Fix AIX build break #3946

wants to merge 1 commit into from

Conversation

KamathForAIX
Copy link
Contributor

Closes #3945

@alexanderguzhva
Copy link
Contributor

lgtm, the change totally makes sense

@kuarora kuarora mentioned this pull request Oct 14, 2024
Closed
2 tasks
@facebook-github-bot
Copy link
Contributor

@kuarora has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@kuarora kuarora changed the title Fix AIX build break [PR] Fix AIX build break Oct 14, 2024
@kuarora kuarora added the ignore label Oct 14, 2024
@mnorris11 mnorris11 removed the ignore label Oct 14, 2024
@mnorris11 mnorris11 mentioned this pull request Oct 15, 2024
Closed
4 tasks
@mnorris11
Copy link

We reverted the external module change already in #3954, so closing the PR.

If/when we re-add it, we will incorporate this logic.

@mnorris11 mnorris11 closed this Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed install
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FAISS build break in AIX (PowerPC)
5 participants
@KamathForAIX @alexanderguzhva @facebook-github-bot @mnorris11 @kuarora