Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Numerous typos in code #3859

Closed
Harry-Chen opened this issue Sep 14, 2024 · 1 comment
Closed

Numerous typos in code #3859

Harry-Chen opened this issue Sep 14, 2024 · 1 comment

Comments

@Harry-Chen
Copy link
Contributor

Summary

Some typos in the code should be handy to fix. They are all detected by Debian's litian with tag spelling-error-in-binary.

Faiss version: dc55e11

  • hanlde -> handle: some files under faiss/impl/
  • identifer -> identifier: faiss/AutoTune.h
  • impemented -> implemented: faiss/IndexIVFFastScan.cpp, faiss/invlists/BlockInvertedLists.cpp
  • implemetation -> implementation: faiss/IndexIVF.h
  • ouptut -> output: faiss/impl/AuxIndexStructures.h, faiss/utils/hamming.cpp
  • strcuture -> structure: some files under faiss/*.h
  • tranforms -> transforms: faiss/IndexPreTransform.h
  • neighors -> neighbors: faiss/utils/distances.h

I can submit a PR if that is acceptable.
@alexanderguzhva
Copy link
Contributor

@Harry-Chen yes, please do!

Harry-Chen added a commit to Harry-Chen/faiss that referenced this issue Sep 15, 2024
@Harry-Chen
Fix several typos in code
c7e0e3e 
All typos are not names of public APIs, thus safe to fix.

Closes facebookresearch#3859

Signed-off-by: Shengqi Chen <harry-chen@outlook.com>
Harry-Chen added a commit to Harry-Chen/faiss that referenced this issue Sep 15, 2024
@Harry-Chen
Fix several typos in code detected by lintian
96938c6 
All typos are not names of public APIs, thus safe to fix.

Closes facebookresearch#3859

Signed-off-by: Shengqi Chen <harry-chen@outlook.com>
@Harry-Chen Harry-Chen mentioned this issue Sep 15, 2024
Closed
aalekhpatel07 pushed a commit to aalekhpatel07/faiss that referenced this issue Oct 17, 2024
@Harry-Chen @aalekhpatel07
Fix several typos in code detected by lintian (facebookresearch#3861)
891e6df 
Summary:
All typos are not names of public APIs, thus safe to fix.

Closes facebookresearch#3859

Pull Request resolved: facebookresearch#3861

Reviewed By: asadoughi

Differential Revision: D62717144

Pulled By: junjieqi

fbshipit-source-id: 647de83ac5d6dba713031c2fc8af7b3f4d84f1d3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix several typos in code detected by lintian Harry-Chen/faiss
2 participants
@Harry-Chen @alexanderguzhva