Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[www] Sahir/UI/code_cleanup #626

Merged

Conversation

sahirgomez1
Copy link
Contributor

This PR fixes:

  • UI bugs on Node v17
  • Adds favicons.
  • Bumps up react-bootstrap to latest version.
  • Styled components.

@sahirgomez1 sahirgomez1 added the www Web frontend label Mar 16, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 16, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 16, 2022

Codecov Report

Merging #626 (f1767d4) into development (e20ba1c) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           development     #626      +/-   ##
===============================================
- Coverage        88.61%   88.60%   -0.02%     
===============================================
  Files              115      115              
  Lines             7019     7019              
===============================================
- Hits              6220     6219       -1     
- Misses             799      800       +1     
Impacted Files Coverage Δ
compiler_gym/envs/llvm/datasets/cbench.py 79.42% <0.00%> (-1.09%) ⬇️
compiler_gym/envs/gcc/service/gcc_service.py 96.70% <0.00%> (-0.37%) ⬇️
...loop_tool/service/loop_tool_compilation_session.py 89.79% <0.00%> (+0.68%) ⬆️
compiler_gym/envs/llvm/llvm_benchmark.py 93.43% <0.00%> (+0.72%) ⬆️
compiler_gym/envs/llvm/compute_observation.py 90.90% <0.00%> (+2.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e20ba1c...f1767d4. Read the comment docs.

@ChrisCummins
Copy link
Contributor

Code LGTM! But the CI/www-build job is failing with error:

/opt/hostedtoolcache/node/16.14.0/x64/bin/node: bad option: --openssl-legacy-provider

Any idea what is going on there?

@sahirgomez1
Copy link
Contributor Author

sahirgomez1 commented Mar 16, 2022

@ChrisCummins you might need to bump up the CI to Node 17.

see here

@ChrisCummins
Copy link
Contributor

@ChrisCummins you might need to bump up the CI to Node 17.

see here

Could you take a look at this? Node version declared here:

https://github.com/facebookresearch/CompilerGym/blob/development/.github/workflows/ci.yaml#L607

Thanks!

@sahirgomez1
Copy link
Contributor Author

Understood. Fixed now.

@ChrisCummins
Copy link
Contributor

Many thanks!

@ChrisCummins ChrisCummins merged commit c5b9289 into facebookresearch:development Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. www Web frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants