Use with statement in place of try/finally for envs.
#384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
This patch refactors the code pattern `try: ...; finally: env.close()` to instead use the `with gym.make(...):` pattern. This is preferred because it automatically handles calling `close()`.
ChrisCummins
force-pushed
the
with-statement
branch
from
50e6377 to
12b4414
Compare
ChrisCummins
added a commit
to hughleat/CompilerGym
that referenced
this pull request
Sep 10, 2021
Regression introduced in facebookresearch#384.
ChrisCummins
added a commit
to ChrisCummins/CompilerGym
that referenced
this pull request
Sep 10, 2021
Regression introduced in facebookresearch#384.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch refactors the code pattern
try: ...; finally: env.close()to instead use the
with gym.make(...):pattern. This is preferredbecause it automatically handles calling
close().