Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CompilerEnv.observation_space should be of type 'Space' #225

Closed
ChrisCummins opened this issue Apr 27, 2021 · 0 comments · Fixed by #228
Closed

CompilerEnv.observation_space should be of type 'Space' #225

ChrisCummins opened this issue Apr 27, 2021 · 0 comments · Fixed by #228
Assignees
@ChrisCummins
Milestone
v0.1.8

Comments

@ChrisCummins
Copy link
Contributor

🐛 Bug

Currently, CompilerGym.observation_space is an ObservationSpaceSpec. This is inconsistent with the gym interface. It should be Space.
@ChrisCummins ChrisCummins added this to the v0.1.8 milestone Apr 28, 2021
ChrisCummins added a commit to ChrisCummins/CompilerGym that referenced this issue Apr 28, 2021
@ChrisCummins
Make CompilerEnv.observation_space a gym.Space.
8ac6575 
This changes the type of observation_space from ObservationSpaceSpec
to gym.Space. This is to maintain compatibility with the gym
interface, which requires that the observation_space is a Space. The
ObservationSpaceSpec is now available at
CompilerEnv.observation_space_spec.

Fixes facebookresearch#225.
@ChrisCummins ChrisCummins mentioned this issue Apr 28, 2021
Merged
ChrisCummins added a commit to ChrisCummins/CompilerGym that referenced this issue Apr 28, 2021
@ChrisCummins
Make CompilerEnv.observation_space a gym.Space.
8b9a620 
This changes the type of observation_space from ObservationSpaceSpec
to gym.Space. This is to maintain compatibility with the gym
interface, which requires that the observation_space is a Space. The
ObservationSpaceSpec is now available at
CompilerEnv.observation_space_spec.

Fixes facebookresearch#225.
bwasti pushed a commit to bwasti/CompilerGym that referenced this issue Aug 3, 2021
@ChrisCummins @bwasti
Make CompilerEnv.observation_space a gym.Space.
bb881d9 
This changes the type of observation_space from ObservationSpaceSpec
to gym.Space. This is to maintain compatibility with the gym
interface, which requires that the observation_space is a Space. The
ObservationSpaceSpec is now available at
CompilerEnv.observation_space_spec.

Fixes facebookresearch#225.
@ChrisCummins ChrisCummins self-assigned this Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChrisCummins ChrisCummins

Labels
None yet
Projects
None yet
Milestone
v0.1.8
Development

Successfully merging a pull request may close this issue.

Make CompilerEnv.observation_space a gym.Space. ChrisCummins/CompilerGym
1 participant
@ChrisCummins