Skip to content

Commit

Permalink
[examples] Put helper functions in anonymous namespace.
Browse files Browse the repository at this point in the history
  • Loading branch information
ChrisCummins committed Mar 19, 2021
1 parent 50b9ac1 commit b1760a6
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,6 @@ template <typename T>
return Status::OK;
}

} // namespace

std::vector<std::string> getBenchmarks() { return {"foo", "bar"}; }

std::vector<ActionSpace> getActionSpaces() {
Expand Down Expand Up @@ -69,6 +67,8 @@ std::vector<ObservationSpace> getObservationSpaces() {
return {ir, features, runtime};
}

} // namespace

ExampleService::ExampleService(const fs::path& workingDirectory)
: workingDirectory_(workingDirectory), nextSessionId_(0) {}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,4 @@ class ExampleCompilationSession {
ActionSpace actionSpace_;
};

// Helper functions to describe the available action/observation/reward spaces.
std::vector<ActionSpace> getActionSpaces();
std::vector<ObservationSpace> getObservationSpaces();

} // namespace compiler_gym::example_service

0 comments on commit b1760a6

Please sign in to comment.