Correctly record the rawInputBytes metric in TableScan #8545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meta-velox canceled.
|
facebook-github-bot
added
the
CLA Signed
|
@Yuhta Can you help to review again? Thanks for your help. |
Yuhta
reviewed
Jan 26, 2024
| @@ -274,6 +274,7 @@ std::vector<cache::CachePin> DirectCoalescedLoad::loadData(bool isPrefetch) { | |||
| } | |||
| input_->read(buffers, requests_[0].region.offset, LogType::FILE); | |||
| ioStats_->read().increment(size); | |||
| ioStats_->incRawBytesRead((size > overread) ? size - overread : 0); | |||
There was a problem hiding this comment.
I think we need to fix the calculation of size here. size += request.loadSize instead of size += std::min<int32_t>(loadQuantum_, region.length) above probably. Do you think that makes sense? Can you think about a test case to cover that?
|
This pull request has been automatically marked as stale because it has not had recent activity. If you'd still like this PR merged, please comment on the PR, make sure you've addressed reviewer comments, and rebase on the latest main. Thank you for your contributions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up #8536 and #8147.
This PR adds a check to set the size to 0 if the difference between the size and overread is less than 0.