refactor: Move alias for column_index_t to Type.h #12477
+5
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
@pedroerp @majetideepak : I'm not fixated on this change, but it could be nice for WindowFunctions and TableFunctions that use a buffer of Vectors without using ComplexVector.h |
Yuhta
reviewed
Feb 27, 2025
velox/vector/BaseVector.h
Outdated
| @@ -51,6 +51,11 @@ class VectorPool; | |||
| class BaseVector; | |||
| using VectorPtr = std::shared_ptr<BaseVector>; | |||
|
|
|||
| using column_index_t = uint32_t; | |||
There was a problem hiding this comment.
This sounds like something at type level, can we move it into Type.h?
There was a problem hiding this comment.
Thanks @Yuhta. That works as well. Have updated the code.
aditi-pandit
force-pushed
the
column_index_t
branch
from
e59142a to
ba478e5
Compare
aditi-pandit
force-pushed
the
column_index_t
branch
from
ba478e5 to
91b86c5
Compare
aditi-pandit
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it simpler to use column_index_t alias in functions which use a buffer of FlatVector columns instead of a ComplexVector.