misc: index lookup fix and test improvements #12465
Closed
+469
−203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D70295117 |
✅ Deploy Preview for meta-velox canceled.
|
xiaoxmeng
added a commit
to xiaoxmeng/velox
that referenced
this pull request
Feb 27, 2025
Summary: Improve index lookup join tests with output batch size, connector error and random data fuzzer test. Also fixed a couple of issues in hash table based index connector used for test Differential Revision: D70295117
xiaoxmeng
force-pushed
the
export-D70295117
branch
from
41e1a3a to
2141d51
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70295117 |
xiaoxmeng
added a commit
to xiaoxmeng/velox
that referenced
this pull request
Feb 27, 2025
Summary: Improve index lookup join tests with output batch size, connector error and random data fuzzer test. Also fixed a couple of issues in hash table based index connector used for test Differential Revision: D70295117
xiaoxmeng
force-pushed
the
export-D70295117
branch
from
2141d51 to
0b084b1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70295117 |
xiaoxmeng
force-pushed
the
export-D70295117
branch
from
0b084b1 to
4072d1d
Compare
xiaoxmeng
added a commit
to xiaoxmeng/velox
that referenced
this pull request
Feb 27, 2025
Summary: Improve index lookup join tests with output batch size, connector error and random data fuzzer test. Also fixed a couple of issues in hash table based index connector used for test Reviewed By: wenqiwooo Differential Revision: D70295117
tanjialiang
approved these changes
Feb 27, 2025
yuandagits
approved these changes
Feb 27, 2025
xiaoxmeng
added a commit
to xiaoxmeng/velox
that referenced
this pull request
Feb 27, 2025
Summary: Pull Request resolved: facebookincubator#12465 Improve index lookup join tests with output batch size, connector error and random data fuzzer test. Also fixed a couple of issues in hash table based index connector used for test Reviewed By: wenqiwooo, tanjialiang, yuandagits Differential Revision: D70295117
|
This pull request was exported from Phabricator. Differential Revision: D70295117 |
xiaoxmeng
force-pushed
the
export-D70295117
branch
from
4072d1d to
e56234c
Compare
xiaoxmeng
added a commit
to xiaoxmeng/velox
that referenced
this pull request
Feb 27, 2025
Summary: Improve index lookup join tests with output batch size, connector error and random data fuzzer test. Also fixed a couple of issues in hash table based index connector used for test Reviewed By: wenqiwooo, tanjialiang, yuandagits Differential Revision: D70295117
xiaoxmeng
force-pushed
the
export-D70295117
branch
from
e56234c to
f87aafa
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70295117 |
xiaoxmeng
added a commit
to xiaoxmeng/velox
that referenced
this pull request
Feb 27, 2025
Summary: Improve index lookup join tests with output batch size, connector error and random data fuzzer test. Also fixed a couple of issues in hash table based index connector used for test Reviewed By: wenqiwooo, tanjialiang, yuandagits Differential Revision: D70295117
xiaoxmeng
force-pushed
the
export-D70295117
branch
from
f87aafa to
0a08ff5
Compare
xiaoxmeng
added a commit
to xiaoxmeng/velox
that referenced
this pull request
Feb 27, 2025
Summary: Improve index lookup join tests with output batch size, connector error and random data fuzzer test. Also fixed a couple of issues in hash table based index connector used for test Reviewed By: wenqiwooo, tanjialiang, yuandagits Differential Revision: D70295117
xiaoxmeng
force-pushed
the
export-D70295117
branch
from
0a08ff5 to
3337ef8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70295117 |
Summary: Pull Request resolved: facebookincubator#12465 Improve index lookup join tests with output batch size, connector error and random data fuzzer test. Also fixed a couple of issues in hash table based index connector used for test Reviewed By: wenqiwooo, tanjialiang, yuandagits Differential Revision: D70295117
|
This pull request was exported from Phabricator. Differential Revision: D70295117 |
xiaoxmeng
force-pushed
the
export-D70295117
branch
from
3337ef8 to
5714fe2
Compare
|
This pull request has been merged in caee268. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Improve index lookup join tests with output batch size, connector error and random data fuzzer test.
Also fixed a couple of issues in hash table based index connector used for test
Differential Revision: D70295117