refactor: Clean up Registration includes from Presto Type headers #12460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D70275631 |
✅ Deploy Preview for meta-velox canceled.
|
kevinwilfong
pushed a commit
to kevinwilfong/velox
that referenced
this pull request
Feb 27, 2025
…cebookincubator#12460) Summary: This is a follow up to facebookincubator#12393 The header files in Presto were fixed in prestodb/presto#24622 so we are now free to separate the Type and Registration files so that Registration depends on Type and not the other way around. Differential Revision: D70275631
kevinwilfong
force-pushed
the
export-D70275631
branch
from
3cb9f77 to
7d0b5bc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70275631 |
…cebookincubator#12460) Summary: This is a follow up to facebookincubator#12393 The header files in Presto were fixed in prestodb/presto#24622 so we are now free to separate the Type and Registration files so that Registration depends on Type and not the other way around. Differential Revision: D70275631
kevinwilfong
force-pushed
the
export-D70275631
branch
from
7d0b5bc to
164fa7c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70275631 |
kevinwilfong
pushed a commit
to kevinwilfong/velox
that referenced
this pull request
Feb 28, 2025
…cebookincubator#12460) Summary: This is a follow up to facebookincubator#12393 The header files in Presto were fixed in prestodb/presto#24622 so we are now free to separate the Type and Registration files so that Registration depends on Type and not the other way around. Differential Revision: D70275631
kevinwilfong
pushed a commit
to kevinwilfong/velox
that referenced
this pull request
Feb 28, 2025
…cebookincubator#12460) Summary: This is a follow up to facebookincubator#12393 The header files in Presto were fixed in prestodb/presto#24622 so we are now free to separate the Type and Registration files so that Registration depends on Type and not the other way around. Differential Revision: D70275631
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This is a follow up to #12393
The header files in Presto were fixed in prestodb/presto#24622 so we are
now free to separate the Type and Registration files so that Registration depends on Type and
not the other way around.
Differential Revision: D70275631