fix(iceberg): Position delete bug while doing upper bound check #12453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While updating the bitmap for delete positions, we are including the exclusive upper bound, leading to incorrectly setting the buffer size
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
nmahadevuni
requested review from
yingsu00
and removed request for
majetideepak
yingsu00
approved these changes
Feb 28, 2025
| @@ -251,7 +251,7 @@ void PositionalDeleteFileReader::updateDeleteBitmap( | |||
| static_cast<uint64_t>(deleteBitmapBuffer->size()), | |||
| deletePositionsOffset_ == 0 || | |||
| (deletePositionsOffset_ < deletePositionsVector->size() && | |||
| deletePositions[deletePositionsOffset_] > rowNumberUpperBound) | |||
| deletePositions[deletePositionsOffset_] >= rowNumberUpperBound) | |||
There was a problem hiding this comment.
Line 249 typo: "all delte files" -> "all delete files"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While updating the bitmap for delete positions, we are including the exclusive upper bound, leading to incorrectly
setting the buffer size.