feat: Support array_intersect(Unknown) #12448
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
@kewang1024 @kevinwilfong @mbasmanova Could you please review it, thanks. |
mbasmanova
reviewed
Feb 26, 2025
There was a problem hiding this comment.
@xiaodouchen Would this function run into same / similar limitation in Fuzzer as array_join?
CC: @kgpai @kagamiori
mbasmanova
requested changes
Feb 26, 2025
| @@ -622,7 +622,10 @@ std::shared_ptr<exec::VectorFunction> createTypedArraysIntersectExcept( | |||
| VELOX_CHECK_EQ(inputArgs.size(), 2); | |||
| const BaseVector* rhs = inputArgs[1].constantValue.get(); | |||
|
|
|||
| if (elementType->providesCustomComparison()) { | |||
| if constexpr (kind == TypeKind::UNKNOWN) { | |||
There was a problem hiding this comment.
UNKNOWN values can only be nulls. Intersecting arrays of NULLs can be done faster by looking at just the array sizes, no?
This change affects array_except function as well? If so, can we add test coverage?
| @@ -735,3 +735,50 @@ TEST_F(ArrayIntersectTest, nullInDictionary) { | |||
| makeNullableArrayVector<int64_t>({{{1}}, std::nullopt, {{7}}}); | |||
| testExpr(expected, "array_intersect(c0)", {arrays}); | |||
| } | |||
|
|
|||
| TEST_F(ArrayIntersectTest, unknownArrays) { | |||
| auto array1 = makeNullableArrayVector<UnknownValue>( | |||
There was a problem hiding this comment.
This is a bit hard to read. Is there a way to extend makeArrayVectorFromJson to work with Unknown?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.