Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(fuzzer): Unlink CacheFuzzer from GTest #12386

Closed
wants to merge 4 commits into from
Closed

refactor(fuzzer): Unlink CacheFuzzer from GTest #12386

wants to merge 4 commits into from

Conversation

xin-zhang2
Copy link
Contributor

@xin-zhang2 xin-zhang2 commented Feb 19, 2025 •
edited by majetideepak
Loading

CacheFuzzer is not a test since it does not use any GTest features.
It is an executable similar to benchmarks.
We must move it from the tests folder into the fuzzer folder.

Fixes #12375

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 19, 2025
@netlify Netlify
Copy link

netlify bot commented Feb 19, 2025 •
edited
Loading

✅ Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit ca493b4
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/67b600088e5d660008d4d111

@xin-zhang2 xin-zhang2 marked this pull request as ready for review February 19, 2025 15:38
duanmeng
duanmeng approved these changes Feb 20, 2025
View reviewed changes
Copy link
Collaborator

@duanmeng duanmeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xin-zhang2 LGTM, thanks.

assignUser
assignUser approved these changes Feb 20, 2025
View reviewed changes
Copy link
Collaborator

@assignUser assignUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the run passes. Thanks for the clean up.

@majetideepak majetideepak added the ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall label Feb 20, 2025
@facebook-github-bot
Copy link
Contributor

@mbasmanova has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@xin-zhang2
Copy link
Contributor Author

Thanks @majetideepak @duanmeng @assignUser for the review.
It looks like there are two workflows awaiting approval. Could you please help approve them?

@facebook-github-bot
Copy link
Contributor

@mbasmanova merged this pull request in 9c94e7f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majetideepak majetideepak majetideepak left review comments

@duanmeng duanmeng duanmeng approved these changes

@assignUser assignUser assignUser approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unlink CacheFuzzer from GTest
5 participants
@xin-zhang2 @facebook-github-bot @majetideepak @duanmeng @assignUser