Correctly record the rawInputBytes metric in TableScan

facebookincubator · Jan 17, 2024 · f08ab75 · f08ab75
1 parent e2af9d7
commit f08ab75
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/velox/dwio/common/DirectBufferedInput.cpp b/velox/dwio/common/DirectBufferedInput.cpp
@@ -274,6 +274,7 @@ std::vector<cache::CachePin> DirectCoalescedLoad::loadData(bool isPrefetch) {
   }
   input_->read(buffers, requests_[0].region.offset, LogType::FILE);
   ioStats_->read().increment(size);
+  ioStats_->incRawBytesRead(size - overread);
   ioStats_->incRawOverreadBytes(overread);
   if (isPrefetch) {
     ioStats_->prefetch().increment(size);

diff --git a/velox/exec/tests/TableScanTest.cpp b/velox/exec/tests/TableScanTest.cpp
@@ -241,7 +241,8 @@ TEST_F(TableScanTest, allColumns) {
   auto scanNodeId = plan->id();
   auto it = planStats.find(scanNodeId);
   ASSERT_TRUE(it != planStats.end());
-  ASSERT_TRUE(it->second.peakMemoryBytes > 0);
+  ASSERT_GT(it->second.peakMemoryBytes, 0);
+  ASSERT_GT(it->second.rawInputBytes, 0);
   EXPECT_LT(0, exec::TableScan::ioWaitNanos());
 }