Skip to content

Commit

Permalink
Correctly record the rawInputBytes metric in TableScan
Browse files Browse the repository at this point in the history
  • Loading branch information
JkSelf committed Jan 4, 2024
1 parent fefd586 commit 1a65207
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion velox/connectors/hive/HiveDataSource.h
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ class HiveDataSource : public DataSource {
const std::shared_ptr<common::Filter>& filter) override;

uint64_t getCompletedBytes() override {
return ioStats_->rawBytesRead();
return ioStats_->read().sum();
}

uint64_t getCompletedRows() override {
Expand Down
1 change: 1 addition & 0 deletions velox/exec/tests/TableScanTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -242,6 +242,7 @@ TEST_F(TableScanTest, allColumns) {
auto it = planStats.find(scanNodeId);
ASSERT_TRUE(it != planStats.end());
ASSERT_TRUE(it->second.peakMemoryBytes > 0);
ASSERT_TRUE(it->second.rawInputBytes > 0);
EXPECT_LT(0, exec::TableScan::ioWaitNanos());
}

Expand Down

0 comments on commit 1a65207

Please sign in to comment.