Skip to content
This repository was archived by the owner on May 28, 2019. It is now read-only.

Various fixes to unbreak the codebase & testing #64

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

dmikushin
Copy link

Dear Authors, thank you for bringing facebookresearch / loop to the world!

This PR aggregates small fixes to various problems seen during pretrained models testing:

  • SPTK path actually needs one extra "/bin/" node
  • Implicit conversion from float to integer is disliked by Python in multiple places
  • Adding appropriate imports of Phenomizer components
  • Changing test example to generate voice for some random text, which should be more interesting for a curious user

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants