Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[easy] minor doc update for --rsyncable #3570

Merged
merged 1 commit into from
Mar 27, 2023
Merged

[easy] minor doc update for --rsyncable #3570

merged 1 commit into from
Mar 27, 2023

Conversation

Cyan4973
Copy link
Contributor

rephrase the speed impact, as suggested by @devZer0.
fix #3567

@devZer0
Copy link

devZer0 commented Mar 23, 2023

There is a negligible impact to compression ratio, and a small impact to compression speed,
only perceptible at higher speeds, typically when combining --rsyncable with many parallel
worker threads.

thank you - but - sorry - i don't want to be dogmatic, nor do i want to be pedantic , rude or a nagger - but even in this optimzed form, what's being claimed here simply isn't true.

otherwise, my perception of "negligible impact" is at least very different from your's.

let me show the difference again:

# dd if=/dev/zero of=zeroes.dat bs=1024k count=4096
4096+0 records in
4096+0 records out
4294967296 bytes (4.3 GB, 4.0 GiB) copied, 2.66998 s, 1.6 GB/s

# dd if=/dev/urandom of=random.dat bs=1024k count=4096
4096+0 records in
4096+0 records out
4294967296 bytes (4.3 GB, 4.0 GiB) copied, 20.9213 s, 205 MB/s

# time /root/zstd/zstd -c random.dat >/dev/null

real	0m4.699s
user	0m7.190s
sys	0m2.999s

# time /root/zstd/zstd -c zeroes.dat >/dev/null

real	0m2.433s
user	0m3.518s
sys	0m2.477s

# time /root/zstd/zstd -c random.dat --rsyncable >/dev/null

real	0m19.598s
user	0m25.092s
sys	0m4.188s

# time /root/zstd/zstd -c zeroes.dat --rsyncable >/dev/null

real	0m18.160s
user	0m20.175s
sys	0m3.692s

@Cyan4973
Copy link
Contributor Author

Cyan4973 commented Mar 23, 2023

my perception of "negligible impact" is at least very different from your's.

The expression "negligible impact" is associated to the concept of "compression ratio", as in the sentence :

There is a negligible impact to compression ratio

If you were to report the compression ratio of the 2 corner case scenarios used as illustration, you would see that this statement holds up pretty well.

@devZer0
Copy link

devZer0 commented Mar 24, 2023

you are right, i mixed that up. sorry for that.

and thank you for fixing the docs!

@Cyan4973 Cyan4973 merged commit 7306832 into dev Mar 27, 2023
@Cyan4973 Cyan4973 deleted the rsync_doc branch March 29, 2023 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

please be more clear about rsyncable performance impact in manpage
3 participants