Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sys/timeb.h is not available on OpenBSD #319

Closed
juanfra684 opened this issue Sep 1, 2016 · 7 comments
Closed

sys/timeb.h is not available on OpenBSD #319

juanfra684 opened this issue Sep 1, 2016 · 7 comments

Comments

@juanfra684
Copy link
Contributor

timeb.h was removed from OpenBSD a few years ago. zbufftest.c doesn't build without it:

zbufftest.c: In function 'FUZ_GetMilliStart':
zbufftest.c:76:18: error: storage size of 'tb' isn't known
     struct timeb tb;
                  ^
zbufftest.c:78:5: warning: implicit declaration of function 'ftime' [-Wimplicit-function-declaration]
     ftime( &tb );
     ^
zbufftest.c:76:18: warning: unused variable 'tb' [-Wunused-variable]
     struct timeb tb;
                  ^
gmake: *** [Makefile:112: zbufftest] Error 1
@Cyan4973
Copy link
Contributor

Cyan4973 commented Sep 1, 2016

Good point.
This can be changed to only rely on <time.h>.

@Cyan4973
Copy link
Contributor

Cyan4973 commented Sep 2, 2016

zbufftest and zstreamtest no longer depend on timeb.h
in latest update on dev branch

@ad-m
Copy link

ad-m commented Sep 2, 2016

Is it ready to close?

@Cyan4973
Copy link
Contributor

Cyan4973 commented Sep 2, 2016

Yes,
though I typically close an issue when the associated fix reaches release status

@juanfra684
Copy link
Contributor Author

There is a remaining #include <sys/timeb.h> in tests/fuzzer.c.

Cyan4973 added a commit that referenced this issue Sep 2, 2016
@Cyan4973
Copy link
Contributor

Cyan4973 commented Sep 2, 2016

yes, right,
this is just an oversight, <timeb.h> is not necessary in fact.
removed

@Cyan4973
Copy link
Contributor

fixed in v1.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants