Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate define for 32/64 ZSTD_WINDOWLOG_MAX #239

Closed
GregSlazinski opened this issue Jul 8, 2016 · 2 comments
Closed

Separate define for 32/64 ZSTD_WINDOWLOG_MAX #239

GregSlazinski opened this issue Jul 8, 2016 · 2 comments

Comments

@GregSlazinski
Copy link

Is it possible to replace the following:

define ZSTD_WINDOWLOG_MAX ((U32)(MEM_32bits() ? 25 : 27))

to:

define ZSTD_WINDOWLOG_MAX_32 25

define ZSTD_WINDOWLOG_MAX_64 27

define ZSTD_WINDOWLOG_MAX ((U32)(MEM_32bits() ? ZSTD_WINDOWLOG_MAX_32 : ZSTD_WINDOWLOG_MAX_64))

I'm targetting both 32/64 platforms, and I want to know the minimum supported value by both platforms, in my case I will always use ZSTD_WINDOWLOG_MAX_32

LZHAM library does the same approach.

Thanks to this I don't need to store the WindowLog size in the compressed stream, but I can always calculate it based on decompressed size (which I already know).

@Cyan4973
Copy link
Contributor

Cyan4973 commented Jul 8, 2016

Yes

@Cyan4973
Copy link
Contributor

Cyan4973 commented Jul 8, 2016

Merged into v0.7.3

@Cyan4973 Cyan4973 closed this as completed Jul 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants