Fix sst_dump not able to open ingested file

[Connor1996]

When investigating #6666, we encounter an error for sst_dump to dump an ingested SST file with global seqno.

Corruption: An external sst file with version 2 have global seqno property with value ��/, while largest seqno in the file is 0）

Same as #5097, it is due to SstFileReader don't know the largest seqno of a file, it will fail this check when it open a file with global seqno.

rocksdb/table/block_based_table_reader.cc

Line 730 in ca89ac2

if (global_seqno != 0 && global_seqno != largest_seqno) {

Test:
run it manually

[yiwu-arbug]

@ajkr mind also merge this one? thanks.

[ajkr]

lgtm.

[facebook-github-bot]

@ajkr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[Connor1996]

have no idea about why the test is failed, could you help me take a look? @ajkr

[ajkr]

test failure appears unrelated:

db_test::DBTest.SparseMerge State: Completed
Note: Google Test filter = DBTest.SparseMerge
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from DBTest
[ RUN      ] DBTest.SparseMerge
c:\projects\rocksdb\db\db_test.cc(1341): error: Expected: (dbfull()->TEST_MaxNextLevelOverlappingBytes(handles_[1])) <= (20 * 1048576), actual: 32700451 vs 20971520
[  FAILED  ] DBTest.SparseMerge (5461 ms)
[----------] 1 test from DBTest (5461 ms total)
[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (5461 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] DBTest.SparseMerge

[facebook-github-bot]

@ajkr merged this pull request in c8c739a.