Disable ESLint's no-extend-native for two lines #9625
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the following two
no-extend-native
warnings by addingeslint-disable-line
comments.I also had to move the code around a bit so both ESLint and Prettier would be satisfied. Initially the code was like like this:
But Prettier moved the comment on the following line, which cased the ESLint warning to appear again.
Moving the comment before the assignment prevented Prettier from reformatting the code but did not disable the warning, so I refactored the code like this:
The PR that introduced the warnings is #9163.