Warn if rendering invalid element, fixes #3726 #8396
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * | ||
| * https://www.w3.org/TR/custom-elements/#custom-elements-api | ||
| */ | ||
| knownTag = !(document.createElement(instance._tag) instanceof UnknownConstructor); |
There was a problem hiding this comment.
does SSR still work with this enabled?
| @@ -253,6 +254,8 @@ if (__DEV__) { | |||
| } | |||
|
|
|||
| validateDOMNesting(null, String(content), this, this._ancestorInfo); | |||
| validateDOMTag(this, this._ancestorInfo); | |||
There was a problem hiding this comment.
I believe the changes in this file should be replicated in the Fiber component as well.
ConnorAtherton
changed the title
|
It would make sense to me to not warn on any tag that has a |
|
Fixed in #9163 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a warning whenever a user attempts to render an element unrecognized by the browser.
TODO
npm test).validateDOMTagmuch likevalidateDOMNestingThe tests for
ReactDOMComponentinclude a lot of custom web components that will now show a warning because they haven't been defined before they were used. I'm not sure how to solve this issue yet. I'm hesitant to change the existing specs and, from an initial glance, it looks like jsdom doesn't fully support the web componentcustomElementsproperty yet. @spicyj Any ideas on how to go around resolving this?Here is a quick look at the warning:
