Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code coverage grunt tasks #550

Merged
merged 14 commits into from
Nov 18, 2013
Merged

code coverage grunt tasks #550

merged 14 commits into from
Nov 18, 2013

Conversation

subtleGradient
Copy link
Contributor

No description provided.

@subtleGradient
Copy link
Contributor Author

Also fixes #541

@subtleGradient
Copy link
Contributor Author

eep, I've got a bug in my finalize-coverage-stream, brb

benjamn
benjamn reviewed Nov 15, 2013
View reviewed changes
grunt/config/server.js
if (log.message.indexOf('not ok ') === 0) log.type = 'error';
else if (log.message.indexOf('ok ') === 0) log.type = 'ok';
else if (log.message.indexOf('COVER') === 0) log.type = 'coverage';
else if (log.message.indexOf('DONE\t') === 0) log.type = 'coverage done';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zpao will probably complain that you should always use braces and break lines, even for if statements like these.

@benjamn
Copy link
Contributor

benjamn commented Nov 18, 2013

@subtleGradient Looks good with those nits addressed.

@subtleGradient
Copy link
Contributor Author

Nits picked. ICANHAZMERGE?

@benjamn
Copy link
Contributor

benjamn commented Nov 18, 2013

u can hazmerge soon as Travis says so

@benjamn benjamn closed this Nov 18, 2013
@benjamn benjamn reopened this Nov 18, 2013
@subtleGradient
Copy link
Contributor Author

Rebased.

@subtleGradient
Copy link
Contributor Author

I don't know what's up with these…

>> not ok 342 - AnalyticsEventPlugin should count events correctly.
# Error: Invariant Violation: createAnalyticsPlugin(...): The DOM is not supported in the execution environment. in http://127.0.0.1:9999/test/index.html (line 48)

>> not ok 344 - AnalyticsEventPlugin error on invalid analytics events.
# Error: Invariant Violation: createAnalyticsPlugin(...): The DOM is not supported in the execution environment. in http://127.0.0.1:9999/test/index.html (line 48)

@subtleGradient
Copy link
Contributor Author

Tests are failing on master. https://travis-ci.org/facebook/react/builds/14155444

@subtleGradient
Copy link
Contributor Author

The Travis CI build is failing because of 7df127d, b91396b and d853c85.

benjamn added a commit that referenced this pull request Nov 18, 2013
@benjamn
Merge pull request #550 from subtleGradient/subtlegradient/code-coverage
5d878ce 
Code coverage grunt tasks.
@benjamn benjamn merged commit 5d878ce into facebook:master Nov 18, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@subtleGradient @benjamn