Fix xplat sync to ignore @generated header #29738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
|
Comparing: 4dcdf21...b617aec Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
jackpope
approved these changes
Jun 3, 2024
| @@ -329,7 +329,7 @@ jobs: | |||
| git status | |||
| echo "====================" | |||
| echo "Checking for changes" | |||
| if git status --porcelain | grep -qv '/REVISION'; then | |||
| if git diff -- . ':(exclude)*REVISION' | grep -vE "^(@@|diff|index|\-\-\-|\+\+\+|@generated SignedSource)" | grep "^[+-]" > /dev/null; then | |||
There was a problem hiding this comment.
Can you add a comment above explaining what its looking for an example of generated header to be matched. Otherwise its going to be rough for the next person who has to adjust this.
github-actions bot
pushed a commit
that referenced
this pull request
Jun 3, 2024
Use some clever git diffing to ignore lines that only change the `@generated` header. We can't do this for the version string because the version string can be embedded in lines with other changes, but this header is always on one line. DiffTrain build for commit 8c3697a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use some clever git diffing to ignore lines that only change the
@generatedheader. We can't do this for the version string because the version string can be embedded in lines with other changes, but this header is always on one line.