Support ReactLink on select elements with multiple set
#1761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We might be considering dropping ReactLink... Need to revisit this if we decide to keep it. |
|
I'm going to close this out because we want to move ReactLink support out of the core components. We will provide helpful wrappers such as React.Addons.Select or something. Once we add that, feel free to add it to the wrapper unless it's already there. See #2302 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReactLinkdoesn't work on select elements withmultipleset sincenode.valueonly returns the value of the element's first selected option. Some discussion over IRC indicated that it might make sense for the behavior to instead match that of thevalueproperty, which allows setting multiple values via an array; this PR implements that behavior.