Push host root context when bailing out on low priority #10712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents a push/pop mismatch when bailing out on HostRoots. This is currently unobservable, because HostRoots never bail out on low priority, but this does happen with prerendering. I found this when rebasing facebook#10624 on top of master.
gaearon
approved these changes
Sep 14, 2017
gaearon
reviewed
Sep 14, 2017
| @@ -686,6 +686,9 @@ module.exports = function<T, P, I, TI, PI, C, CX, PL>( | |||
| // TODO: Handle HostComponent tags here as well and call pushHostContext()? | |||
There was a problem hiding this comment.
What about this TODO btw?
There was a problem hiding this comment.
Looks like the same issue, but for HostComponents. This whole function is a code smell, IMO. Ideally we'd bail out on low priority before we ever call performUnitOfWork. I tried this out on my big refactor PR from earlier this summer. Will revisit when we add back resuming.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents a push/pop mismatch when bailing out on HostRoots. This is currently unobservable, because HostRoots never bail out on low priority, but this does happen with prerendering.
I found this when rebasing #10624 on top of master. Submitting the fix in its own PR in to make sure I don't forget about it, in case my prerendering PR doesn't land as-is.