[CameraRoll] support fetching videos from the camera roll #774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…both videos and photos
facebook-github-bot
added
the
CLA Signed
|
cc @sahrens |
| /** | ||
| * Specifies filter on asset type, like 'all', 'photos' or 'videos' | ||
| */ | ||
| assetType: ReactPropTypes.string, |
There was a problem hiding this comment.
can you make it ReactPropTypes.oneOf(['all', 'photos', 'videos']) instead of writing it in the comments. The comment can say that all is the default
|
|
…ing PropTypes.oneOf. Add support for asset types to CameraRollView.
|
The latest commit makes Photos the default, fixes the propTypes, and adds support for this property to CameraRollView. |
brentvatne
changed the title
|
Can you squash your commits? |
| @@ -85,7 +87,7 @@ - (void)callCallback:(RCTResponseSenderBlock)callback withAssets:(NSArray *)asse | |||
| } else { | |||
| groupTypes = ALAssetsGroupSavedPhotos; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Make sure to remove the trailing whitespace.
|
Can you add another selector thingy for assetType to CameraRollViewExample in a followup PR? |
bartolkaruza
pushed a commit
to bartolkaruza/react-native-cameraroll
that referenced
this pull request
Feb 23, 2019
Summary: This adds a parameter for fetching videos from the camera roll. It also changes the default to fetch both videos and photos. Closes facebook/react-native#774 Github Author: Joshua Sierles <joshua@diluvia.net> Test Plan: Imported from GitHub, without a `Test Plan:` line.
ayushjainrksh
referenced
this pull request
in MLH-Fellowship/react-native
Jul 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a parameter for fetching videos from the camera roll. It also changes the default to fetch both videos and photos.